Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter undefined factory addresses #5340

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

ljankovic-txfusion
Copy link
Collaborator

Description

When deploying Hyperlane contracts using warp deploy, the core addresses obtained using older version of core deploy may not include addresses of newer factories (staticMessageIdWeightedMultisigIsmFactory and staticMessageIdWeightedMultisigIsmFactory). These undefined addresses would cause warp deploy to fail, even though they aren't absolutely necessary for warping.

This fix handles undefined factory addresses that are filtered out during warp deploy. This way, warp deploy can proceed the weighted factories, and users won't have to pay gas fees for core deployment once again to.

Attached LogX chain core deployment lacking weighted factory addresses & the resulting error message from warp deploy

2025-01-30 16 30 55

2025-01-30 16 30 39

Drive-by changes

  • Added undefined address filtering in the filterAddressesMap function

Related issues

None

Backward compatibility

Yes

Testing

Manual

Copy link

changeset-bot bot commented Jan 30, 2025

🦋 Changeset detected

Latest commit: 7276d7a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/cli Patch
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/widgets Patch
@hyperlane-xyz/ccip-server Patch
@hyperlane-xyz/github-proxy Patch
@hyperlane-xyz/utils Patch
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (68c2f86) to head (7276d7a).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5340   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

typescript/sdk/src/contracts/contracts.ts Outdated Show resolved Hide resolved
typescript/sdk/src/contracts/contracts.ts Outdated Show resolved Hide resolved
typescript/sdk/src/contracts/contracts.ts Outdated Show resolved Hide resolved
typescript/sdk/src/contracts/contracts.ts Outdated Show resolved Hide resolved
@paulbalaji paulbalaji enabled auto-merge January 31, 2025 14:55
@paulbalaji paulbalaji added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit ac984a1 Jan 31, 2025
40 of 42 checks passed
@paulbalaji paulbalaji deleted the fix/filter-undefined-factory-addresses branch January 31, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants