-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: filter undefined factory addresses #5340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actory addresses from the addresses map
🦋 Changeset detectedLatest commit: 7276d7a The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paulbalaji
approved these changes
Jan 30, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5340 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 103 103
Lines 2110 2110
Branches 190 190
=======================================
Hits 1636 1636
Misses 453 453
Partials 21 21
|
ltyu
reviewed
Jan 30, 2025
ltyu
approved these changes
Jan 30, 2025
nambrot
reviewed
Jan 30, 2025
… address fallback
paulbalaji
reviewed
Jan 31, 2025
paulbalaji
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When deploying Hyperlane contracts using
warp deploy
, the core addresses obtained using older version ofcore deploy
may not include addresses of newer factories (staticMessageIdWeightedMultisigIsmFactory
andstaticMessageIdWeightedMultisigIsmFactory
). Theseundefined
addresses would cause warp deploy to fail, even though they aren't absolutely necessary for warping.This fix handles undefined factory addresses that are filtered out during
warp deploy
. This way, warp deploy can proceed the weighted factories, and users won't have to pay gas fees for core deployment once again to.Attached LogX chain core deployment lacking weighted factory addresses & the resulting error message from
warp deploy
Drive-by changes
undefined
address filtering in thefilterAddressesMap
functionRelated issues
None
Backward compatibility
Yes
Testing
Manual