Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for amount routing ism #5406

Open
wants to merge 21 commits into
base: ccip-warp-route
Choose a base branch
from

Conversation

xeno097
Copy link
Contributor

@xeno097 xeno097 commented Feb 7, 2025

Description

This PR adds support for the new AmountRoutingISM in both the CLI and the SDK.

  • Updates the MetadataBuilder to successfully derive the new ISM config
  • Updates the HyperlaneIsmFactory to deploy the new ISM
  • Updates the EvmIsmReader to successfully read data from an AmountRoutingIsm
  • Updates existing tests to deploy the new ISM
  • Adds a warp-send test to verify successful message self-relaying when using the new ISM

image

Drive-by changes

Related issues

Backward compatibility

  • YES

Testing

  • unit
  • e2e
  • manual

Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: 61a0a0e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/cli Minor
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/core Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/github-proxy Minor
@hyperlane-xyz/utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@xeno097 xeno097 requested a review from nambrot February 7, 2025 22:50
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.11%. Comparing base (5002496) to head (51e7ac0).

Additional details and impacted files
@@               Coverage Diff                @@
##           ccip-warp-route    #5406   +/-   ##
================================================
  Coverage            77.11%   77.11%           
================================================
  Files                  109      109           
  Lines                 2163     2163           
  Branches               193      193           
================================================
  Hits                  1668     1668           
  Misses                 474      474           
  Partials                21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 77.93% <ø> (ø)
isms 81.60% <ø> (ø)
token 91.66% <ø> (ø)
middlewares 79.80% <ø> (ø)

@xeno097 xeno097 requested a review from nambrot February 9, 2025 23:38
Base automatically changed from amount-routing-ism to ccip-warp-route February 11, 2025 22:44
@paulbalaji
Copy link
Contributor

the current failing yarn-test will self resolve after merging #5432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

4 participants