Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add multicast tx submission for Ethereum fallback provider #5446

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ameten
Copy link
Contributor

@ameten ameten commented Feb 12, 2025

Description

Add multicast tx submission for Ethereum fallback provider.

EthereumFallbackProvider will use different strategies to query chain RPCs:

  1. If the method is eth_sendRawTransaction, it will make a parallel query to all RPC endpoints and return the first successful result. If no success, it will retry 4 times.
  2. For other methods, the current functionality does not change: it will sequentially query RPC endpoints according to their priorities and adjust priorities depending on success/failure. It also retries 4 times.

Related issues

Backward compatibility

Yes

Testing

Added unit tests

Copy link

changeset-bot bot commented Feb 12, 2025

⚠️ No Changeset found

Latest commit: 44b36b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (d6724c4) to head (d7bd19e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5446   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@ameten ameten changed the title Add log in Ethereum fallback provider for method feat: Add multicast tx submission for Ethereum fallback provider Feb 12, 2025
@ameten ameten force-pushed the ameten/multicast-submit branch from d7bd19e to 9d82eba Compare February 14, 2025 11:18
@ameten ameten force-pushed the ameten/multicast-submit branch from 9d82eba to 44b36b2 Compare February 14, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants