Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CCIP messages should not be DoSable #5448

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

yorhodes
Copy link
Member

@yorhodes yorhodes commented Feb 12, 2025

Description

Enable out of order message execution to prevent DoS.

Set gas limit to benchmark form forge test --isolate.

Use 0 instead of msg.value in CCIP ISM.

Backward compatibility

Yes

Testing

Unit/Fork Tests

Copy link

changeset-bot bot commented Feb 12, 2025

⚠️ No Changeset found

Latest commit: 2e3da3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/core Minor
@hyperlane-xyz/helloworld Patch
@hyperlane-xyz/sdk Patch
@hyperlane-xyz/infra Patch
@hyperlane-xyz/cli Patch
@hyperlane-xyz/widgets Patch
@hyperlane-xyz/ccip-server Patch
@hyperlane-xyz/github-proxy Patch
@hyperlane-xyz/utils Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.11%. Comparing base (57137da) to head (2e3da3c).
Report is 3 commits behind head on ccip-warp-route.

Additional details and impacted files
@@               Coverage Diff                @@
##           ccip-warp-route    #5448   +/-   ##
================================================
  Coverage            77.11%   77.11%           
================================================
  Files                  109      109           
  Lines                 2163     2163           
  Branches               193      193           
================================================
  Hits                  1668     1668           
  Misses                 474      474           
  Partials                21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 77.93% <ø> (ø)
isms 81.60% <0.00%> (ø)
token 91.66% <ø> (ø)
middlewares 79.80% <ø> (ø)

@yorhodes yorhodes merged commit df0eb83 into ccip-warp-route Feb 12, 2025
39 of 41 checks passed
@yorhodes yorhodes deleted the ccip-remediation branch February 12, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants