Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reading ccip hook/ism addresses #5461

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

paulbalaji
Copy link
Contributor

Description

We write with _, but mistakenly read with the old -. This fixes that.

Backward compatibility

Yes

Testing

Unit Tests### Description

Drive-by changes

Related issues

Backward compatibility

Testing

manual

Copy link

changeset-bot bot commented Feb 13, 2025

⚠️ No Changeset found

Latest commit: 4bdb452

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@paulbalaji paulbalaji requested review from nambrot and removed request for ltyu February 13, 2025 00:00
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.11%. Comparing base (5002496) to head (4bdb452).
Report is 1 commits behind head on ccip-warp-route.

Additional details and impacted files
@@               Coverage Diff                @@
##           ccip-warp-route    #5461   +/-   ##
================================================
  Coverage            77.11%   77.11%           
================================================
  Files                  109      109           
  Lines                 2163     2163           
  Branches               193      193           
================================================
  Hits                  1668     1668           
  Misses                 474      474           
  Partials                21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 77.93% <ø> (ø)
isms 81.60% <ø> (ø)
token 91.66% <ø> (ø)
middlewares 79.80% <ø> (ø)

@paulbalaji paulbalaji merged commit e6a82ff into ccip-warp-route Feb 13, 2025
37 of 38 checks passed
@paulbalaji paulbalaji deleted the pb/fix-ccip-read branch February 13, 2025 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants