feat: add USDC token fees testnet warp route (arbitrumsepolia-basesepolia) - #1577
Open
troykessler wants to merge 1 commit into
Open
feat: add USDC token fees testnet warp route (arbitrumsepolia-basesepolia)#1577troykessler wants to merge 1 commit into
troykessler wants to merge 1 commit into
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR adds a new USDC token-fees warp route for Arbitrum Sepolia and Base Sepolia, including token metadata, cross-chain connections, deployment entries, and a changeset bump for ChangesUSDC token-fees route
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@deployments/warp_routes/USDC/arbitrumsepolia-basesepolia-token-fees-config.yaml`:
- Around line 3-7: Add provenance breadcrumbs for the changed USDC warp route
addresses in the token-fees config so future verification can trace them back to
the source deployment transaction or monorepo PR. Update the entries around
addressOrDenom, collateralAddressOrDenom, and connections in the
arbitrumsepolia-basesepolia-token-fees-config.yaml mapping to include a brief
comment/note with the source reference, and apply the same treatment to the
other affected block mentioned in the review.
In
`@deployments/warp_routes/USDC/arbitrumsepolia-basesepolia-token-fees-deploy.yaml`:
- Around line 1-11: The per-chain mappings in this deployment YAML are not
alphabetized, so update the key order within each chain block to keep the inner
entries sorted consistently. Reorder the entries under arbitrumsepolia and
basesepolia so feeHook comes before mailbox, owner, token, and type, matching
the existing alphabetical key convention used in this config.
- Around line 2-11: Add provenance notes to the deployed address entries in the
USDC warp routes deployment YAML so mailbox, owner, token, and feeHook values
can be traced back to their source. Update the relevant address fields in this
deployment config to include a brief source reference (for example, deployment
transaction, upstream PR, or other provenance marker) while keeping the existing
structure for the arbitrumsepolia and basesepolia entries intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d2aa3112-fb10-4393-879b-cfa8fbcacade
📒 Files selected for processing (3)
.changeset/strong-spiders-call.mddeployments/warp_routes/USDC/arbitrumsepolia-basesepolia-token-fees-config.yamldeployments/warp_routes/USDC/arbitrumsepolia-basesepolia-token-fees-deploy.yaml
Comment on lines
+3
to
+7
| - addressOrDenom: "0x2bef59e84615371304bd731601f6344F5F304504" | ||
| chainName: arbitrumsepolia | ||
| collateralAddressOrDenom: "0x75faf114eafb1BDbe2F0316DF893fd58CE46AA4d" | ||
| connections: | ||
| - token: ethereum|basesepolia|0x7e163aE6A31956Cb166B7426d508e1f346465d56 |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add provenance for these address changes.
These addresses land without a note pointing back to the source deployment tx or monorepo PR, so later verification gets muddy fast. Please add that breadcrumb near the changed values.
Also applies to: 13-16
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@deployments/warp_routes/USDC/arbitrumsepolia-basesepolia-token-fees-config.yaml`
around lines 3 - 7, Add provenance breadcrumbs for the changed USDC warp route
addresses in the token-fees config so future verification can trace them back to
the source deployment transaction or monorepo PR. Update the entries around
addressOrDenom, collateralAddressOrDenom, and connections in the
arbitrumsepolia-basesepolia-token-fees-config.yaml mapping to include a brief
comment/note with the source reference, and apply the same treatment to the
other affected block mentioned in the review.
Source: Coding guidelines
Comment on lines
+1
to
+11
| arbitrumsepolia: | ||
| mailbox: "0x598facE78a4302f11E3de0bee1894Da0b2Cb71F8" | ||
| owner: "0x1cFd6A81e98de59e3eeB3AE35c3cb13FCb586E1E" | ||
| token: "0x75faf114eafb1BDbe2F0316DF893fd58CE46AA4d" | ||
| type: collateral | ||
| feeHook: "0x473a72465299C757eD0EA81FC829556E344f856F" | ||
| basesepolia: | ||
| mailbox: "0x6966b0E55883d49BFB24539356a2f8A673E02039" | ||
| owner: "0x1cFd6A81e98de59e3eeB3AE35c3cb13FCb586E1E" | ||
| type: synthetic | ||
| feeHook: "0xbF49AbFF53851817ae6cF4797af6e5c153113988" |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Sort the per-chain YAML keys alphabetically.
The inner mapping order is off in both chain blocks — feeHook should sort ahead of mailbox, owner, token, and type. ESLint usually keeps this tidy, so it’s worth straightening now.
🧰 Tools
🪛 Betterleaks (1.5.0)
[high] 4-4: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@deployments/warp_routes/USDC/arbitrumsepolia-basesepolia-token-fees-deploy.yaml`
around lines 1 - 11, The per-chain mappings in this deployment YAML are not
alphabetized, so update the key order within each chain block to keep the inner
entries sorted consistently. Reorder the entries under arbitrumsepolia and
basesepolia so feeHook comes before mailbox, owner, token, and type, matching
the existing alphabetical key convention used in this config.
Source: Coding guidelines
Comment on lines
+2
to
+11
| mailbox: "0x598facE78a4302f11E3de0bee1894Da0b2Cb71F8" | ||
| owner: "0x1cFd6A81e98de59e3eeB3AE35c3cb13FCb586E1E" | ||
| token: "0x75faf114eafb1BDbe2F0316DF893fd58CE46AA4d" | ||
| type: collateral | ||
| feeHook: "0x473a72465299C757eD0EA81FC829556E344f856F" | ||
| basesepolia: | ||
| mailbox: "0x6966b0E55883d49BFB24539356a2f8A673E02039" | ||
| owner: "0x1cFd6A81e98de59e3eeB3AE35c3cb13FCb586E1E" | ||
| type: synthetic | ||
| feeHook: "0xbF49AbFF53851817ae6cF4797af6e5c153113988" |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add provenance for the deployed addresses too.
Same story here: mailbox, owner, token, and fee hook addresses should carry a quick source note so folks can trace them back to the deployment tx or upstream PR without spelunking.
🧰 Tools
🪛 Betterleaks (1.5.0)
[high] 4-4: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@deployments/warp_routes/USDC/arbitrumsepolia-basesepolia-token-fees-deploy.yaml`
around lines 2 - 11, Add provenance notes to the deployed address entries in the
USDC warp routes deployment YAML so mailbox, owner, token, and feeHook values
can be traced back to their source. Update the relevant address fields in this
deployment config to include a brief source reference (for example, deployment
transaction, upstream PR, or other provenance marker) while keeping the existing
structure for the arbitrumsepolia and basesepolia entries intact.
Source: Coding guidelines
Contributor
|
Check Warp Deploy Summary Check Warp Deploy Summary
Last updated: 2026-06-26 14:59:20 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x2bef59e84615371304bd731601f6344F5F304504), synthetic on basesepolia (0x7e163aE6A31956Cb166B7426d508e1f346465d56)feeHookaddresses for testing token fee functionalityTest plan
🤖 Generated with Claude Code