-
Notifications
You must be signed in to change notification settings - Fork 102
fix: add missing defaultRpcConsensusType agent config doc
#364
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
daniel-savu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! some small things to change
docs/operate/config-reference.mdx
Outdated
| **The consensus type currently only applies to EVM chains.** | ||
|
|
||
| Connections to non-EVM chains only support a single RPC url. If more than one RPC url is specified in [rpcUrls](#chainschain_namerpcurls), only the first one will be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we've recently added fallback provider support to both the cosmwasm and sealevel providers, so this statement can be changed to mention that, and also that quorum provider is still only available on EVM chains (in the section about rpcConsensusType as well pls)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in 163547b
|
|
||
| ::: | ||
|
|
||
| **Description:** How to communicate with the provider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would mention that defaultRpcConsensusType is only used when building EVM providers: https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/2d84c0f961f25c5c9b6580247cd1ae28b02a9fdd/rust/main/hyperlane-base/src/settings/parser/connection_parser.rs#L468
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in 163547b
docs/operate/config-reference.mdx
Outdated
|
|
||
| <TabItem value="env" label="As Env"> | ||
| ```bash | ||
| export HYP_DEFAULT_RPCCONSENSUSTYPE="single" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| export HYP_DEFAULT_RPCCONSENSUSTYPE="single" | |
| export HYP_DEFAULTRPCCONSENSUSTYPE="single" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed in 5849a4e
Reference for main repo agent code