Refactor function to process mention tags #6826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6826 +/- ##
==========================================
- Coverage 99.42% 99.42% -0.01%
==========================================
Files 272 272
Lines 10451 10446 -5
Branches 2503 2507 +4
==========================================
- Hits 10391 10386 -5
Misses 60 60 ☔ View full report in Codecov by Sentry. |
acelaya
commented
Feb 14, 2025
| element: HTMLElement, | ||
| mentions: Mention[], | ||
| ): Map<HTMLElement, Mention | InvalidUsername> { | ||
| const mentionLinks = element.querySelectorAll('a[data-hyp-mention]'); | ||
| const unprocessedMentionTags = element.querySelectorAll( | ||
| 'a[data-hyp-mention]:not([data-hyp-mention-type])', |
There was a problem hiding this comment.
I have added the extra :not([data-hyp-mention-type]) condition to the selector, to make sure already processed mentions are not processed again.
acelaya
force-pushed
the
refactor-render-mention-tags
branch
from
a4f86ad to
70fbdd3
Compare
robertknight
approved these changes
Feb 14, 2025
acelaya
force-pushed
the
refactor-render-mention-tags
branch
from
70fbdd3 to
824c54d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/orgs/hypothesis/projects/153/views/1?pane=issue&itemId=97415193
Refactor the
renderMentionTagsfunction, which has been renamed toprocessAndReplaceMentionElements, so that it is more obvious that it has side effects and mutates provided DOM element.