Only emit rename event for altered workspaces. #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-fff
force-pushed
the
mw/selective-name-emit
branch
3 times, most recently
from
0e360e7 to
d9ae92b
Compare
matt-fff
force-pushed
the
mw/selective-name-emit
branch
4 times, most recently
from
e1e1833 to
1408fed
Compare
matt-fff
force-pushed
the
mw/selective-name-emit
branch
2 times, most recently
from
2eaf478 to
7542e26
Compare
matt-fff
force-pushed
the
mw/selective-name-emit
branch
3 times, most recently
from
e126650 to
6ef43cb
Compare
cyrinux
approved these changes
Jan 27, 2025
|
Thanks @matt-fff, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently this project emits rename events for all workspaces on every workspace change.
This can make things slow for downstream Hyprland rename event consumers, which have to process numerous redundant events. For users with a lot of workspaces, this can cause a perceptible amount of delay (and redundant logs) in downstream applications.
Type of change
How Has This Been Tested?
Added new unit tests for the workspace cache.
I have been running this version of hyprland-autoname-workspaces on my main desktop without issue.