Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hyprland-rs 0.4.0-beta.2 #119

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

matt-fff
Copy link
Collaborator

@matt-fff matt-fff commented Jan 12, 2025

Description

Updates hyprland-rs to 0.4.0-beta.2

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Relying on existing unit tests and testing it locally on my system.

@matt-fff matt-fff requested a review from cyrinux January 12, 2025 03:55
@matt-fff
Copy link
Collaborator Author

The only test failures are pre-existing and not related to the changes.

@matt-fff matt-fff marked this pull request as ready for review January 12, 2025 03:56
@matt-fff matt-fff marked this pull request as draft January 12, 2025 03:59
@cyrinux
Copy link
Collaborator

cyrinux commented Jan 12, 2025

It looks good for me.

But any reason you remove silent?

For info, It will be very verbose for end user if a event if not handle by hyperland-rs - if this feature flag still exist.
Maybe we should if possible have a set of feature for dev and release mode?

@matt-fff
Copy link
Collaborator Author

matt-fff commented Jan 12, 2025

It looks good for me.

But any reason you remove silent?

For info, It will be very verbose for end user if a event if not handle by hyperland-rs - if this feature flag still exist. Maybe we should if possible have a set of feature for dev and release mode?

Yeah, @cyrinux I removed silent because it was removed in hyprland-community/hyprland-rs@b4ff36a. I don't think there's any equivalent, currently.

@matt-fff matt-fff force-pushed the mw/hyprland-0.4.0-beta-2 branch from e18daf4 to 43a73ed Compare January 12, 2025 16:43
@matt-fff matt-fff marked this pull request as ready for review January 12, 2025 16:44
@matt-fff
Copy link
Collaborator Author

matt-fff commented Jan 12, 2025

It looks to me like the verbose logging for unknown events was removed (hyprland-community/hyprland-rs@b4ff36a#diff-c8a4a4f1c07565340179fe7fbd175cd1cabf756f8010591742a6a5993227724fL529-L539) at the same time, so the silent feature is no longer necessary.

@matt-fff matt-fff merged commit ba126d5 into hyprland-community:main Jan 12, 2025
4 checks passed
@matt-fff matt-fff deleted the mw/hyprland-0.4.0-beta-2 branch January 12, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants