begin using CFileDescriptor from hyprutils #9122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gulafaran
force-pushed
the
fds
branch
3 times, most recently
from
df8957b to
10a2c09
Compare
vaxerski
reviewed
Jan 22, 2025
gulafaran
force-pushed
the
fds
branch
2 times, most recently
from
d5b42f2 to
8a9120f
Compare
vaxerski
reviewed
Jan 23, 2025
gulafaran
force-pushed
the
fds
branch
4 times, most recently
from
37643d0 to
0c81948
Compare
make use of the new hyprutils CFileDescriptor instead of manual FD handling.
make use of the new hyprutils CFileDescriptor instead of manual FD handling.
make use of the new CFileDescriptor instead of manual FD handling, also in sendKeymap remove dead code, it already early returns if keyboard isnt valid, and dont try to close the FD that ikeyboard owns.
make SHMFile misc functions use CFileDescriptor and its associated usage in dmabuf and keyboard.
begin using CFileDescriptor in explicit sync and its timelines and eglsync usage in opengl, there is still a bit left with manual handling that requires future aquamarine change aswell.
make use of the hyprutils CFileDescriptor instead of manual FD and socket handling and closing.
make the timerfd use CFileDescriptor instead of manual fd handling
make the gbm rendernode fd use CFileDescriptor instead of manual fd handling
make data selection source and offers use CFileDescriptor and its associated use in xwm and protocols
make most fd handling use CFileDescriptor in protocols
make SHMPool use CFileDescriptor instead of manual fd handling.
duplicate fenceFD with CFileDescriptor duplicate instead.
instead of manual opening/closing make sockets and fds use CFileDescriptor
make sockets and fds use CFileDescriptor instead of manual handling.
vaxerski
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
its big, it touches many things. and it can be sneaky if fd's suddenly close at wrong time or begins rampantly leaking. so this warrants some testing. and reviewing.
this moves most fd handling over to CFileDescriptor while leaving the bits that is intertwined with aquamarine. the aquamarine bits is for future PR. IKeyboard also got a few lines of seemingly dead code removed unless the intention there originally was something else.