Support content-type-v1 proto #9226
Conversation
|
DS is not ready for auto enabling. It has buffer release / timing issues (esp on amd) |
|
what about enabling tearing for games? |
|
we already have the tearing hint protocol for that |
UjinT34
force-pushed
the
content-type-v1
branch
from
8307aaa to
9fd5345
Compare
| @@ -19,6 +19,7 @@ | |||
| #include "WLSurface.hpp" | |||
| #include "Workspace.hpp" | |||
| #include "WindowRule.hpp" | |||
| #include "protocols/types/ContentType.hpp" | |||
There was a problem hiding this comment.
My plugin doesn't build because of this line, with the following error:
╰─❯ make all
Hyprland headers found.
Building with XWayland support.
g++ -shared -g -fPIC --no-gnu-unique -std=c++23 `pkg-config --cflags pixman-1 libdrm hyprland` -Iinclude -DWLR_USE_UNSTABLE src/main.cpp -o split-monitor-workspaces.so
In file included from /usr/include/hyprland/src/Compositor.hpp:8,
from src/main.cpp:3:
/usr/include/hyprland/src/desktop/Window.hpp:22:10: fatal error: protocols/types/ContentType.hpp: No such file or directory
22 | #include "protocols/types/ContentType.hpp"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:38: split-monitor-workspaces.so] Error 1
It does build if I change the line to #include "../protocols/types/ContentType.hpp" (which is also where the actual file is). Any ideas why this happens?
There was a problem hiding this comment.
It might be a correct path when building from the source directory. Otherwise it's strange that CI didn't catch it. Most of the imports in this PR are generated by IDE.
There was a problem hiding this comment.
Most of the imports in this PR are generated by IDE.
Did you work in the src/ folder in your IDE while developing this, instead of the root folder?
There was a problem hiding this comment.
oh yeah I missed this... we can't have imports using src paths
always relative
There was a problem hiding this comment.
You missed one in src/desktop/Window.hpp
There was a problem hiding this comment.
and in src/events/Windows.cpp
and likely some other places ;)
Describe your PR, what does it fix/add?
cursor:no_break_fs_vrrnow defaults to 2 - auto: enabled for content type "game" Window Rule for VRR #7621render:direct_scanoutcan be set to 2 - auto: enabled for content type "game"content:TYPEcontent TYPETYPEisnone,photo,videoorgameIs there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
If there are any clients which support this proto and set the type to "game" than new defaults might be unexpected.
Window rule is static. Any reason to make it dynamic?
Needs some testing with different AQ versions. Should be able to build with and without
output->state->setContentTypesupport.Meson build is untested.
Is it ready for merging, or does it need work?
Ready. drm part is not important, requires hyprwm/aquamarine#140 with a version bump. Assumes that 0.7.3 will have it merged.