-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Add a test suite #9297
base: main
Are you sure you want to change the base?
Core: Add a test suite #9297
Conversation
Good idea, but I suggest we use https://nix.dev/tutorials/nixos/integration-testing-using-virtual-machines.html. These are much simpler to use since we don't need to build our own testing framework, and there are plenty of examples to help. I'll try to cook something up today or tomorrow if I have time. |
what? Just run the tester and fail if it returns non-zero |
there are a lot of magic numbers, should they be extracted? |
This is cool ; ) Do we want something like Also is there a reason why we don't want to allow passing the path to Hyprland binary and a path to the test suite directory right away? |
swap config sounds kinda sus ngl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why cant we just use the config from the examples, everything else can be done via ipc like paideia mentioned
https://github.com/hyprwm/Hyprland/blob/main/example/hyprland.conf
Probably not, use the config which is in the tester directory and the rest can be IPC
No, just laziness. |
easier and faster to just append a few things to a special config file |
712cbe6
to
5f81b76
Compare
Needed for `ctest` to detect and run the tests.
XWayland fails
the latter does not exist on nixos
Currently we only test whether hyprland compiles, but we don't actually test... well, anything else.
This MR is a WIP that adds a test suite.
For now it runs, works, and tests spawing two kitties with smart gaps, that's about it.
TODOs:
@fufexan nix, meson, ci pls? Tester needs to be ran from
/hyprtester
, btw.cc @PaideiaDilemma @gulafaran