Unbreak build with libc++ #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/renderer/AsyncResourceGatherer.cpp:98:22: error: no viable overloaded '+='
98 | progress += 1.0 / (preloads + 1.0);
| ~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~
src/renderer/widgets/IWidget.cpp:41:44: error: no member named 'current_zone' in namespace 'std::chrono'
41 | const auto current_zone = std::chrono::current_zone();
| ~~~~~~~~~~~~~^
Closed
|
I will try llvm 18 sortly with and without this PR. Would be good to add your patch in the guru ebuild. (My gentoo machine is still compiling the llvm stack) |
|
You merge it after doing the test on my machine :). Seems to compile just fine, just need to check if all feature work well and then I can close my issue as well |
|
Ok scratch what I said above I still have gcc set and dint notice. My CXXFLAGS: |
|
Ok I found the fix one file require: |
MrDuartePT
added a commit
to MrDuartePT/hyprlock
that referenced
this pull request
Feb 23, 2024
src/config/ConfigManager.cpp:91:6: error: no type named 'mutex' in namespace 'std'
91 | std::mutex configMtx;
| ~~~~~^
src/config/ConfigManager.cpp:94:10: error: no member named 'lock_guard' in namespace 'std'
94 | std::lock_guard<std::mutex> lg(configMtx);
| ~~~~~^
/var/tmp/portage/gui-apps/hyprlock-9999/work/hyprlock-9999/src/config/ConfigManager.cpp:94:26: error: no member named 'mutex' in namespace 'std'
94 | std::lock_guard<std::mutex> lg(configMtx);
| ~~~~~^
Complete what is missing in hyprwm#73
Signed-off-by: Gonçalo Negrier Duarte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70. Tested with Clang/libc++ 17
current_zone