Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make post run script available for both Run and RunE functions #478

Merged

Conversation

kgrigorev
Copy link
Contributor

User of Flamingo Framework can bind a cobra command which defines RunE function and not Run. In this case, the global post function which triggers flamingo.ShutdownEvent won't be run

@kgrigorev kgrigorev self-assigned this Feb 20, 2025
@tessig tessig enabled auto-merge (squash) February 20, 2025 14:04
@tessig tessig merged commit 7bbfff7 into i-love-flamingo:master Feb 20, 2025
5 checks passed
This was referenced Feb 20, 2025
@kgrigorev kgrigorev deleted the add_persistent_postrun_with_error branch February 21, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants