feat(agent-settings): support custom image avatars for custom agents#3325
Open
szafranski wants to merge 2 commits into
Open
feat(agent-settings): support custom image avatars for custom agents#3325szafranski wants to merge 2 commits into
szafranski wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
176db5c to
a89a79a
Compare
c142052 to
f1b3fbd
Compare
500515a to
8c3920e
Compare
Custom agents could previously only use an emoji avatar. Add an Arco Upload control in the inline editor so a user can pick an image file, inlined as a base64 data-URL into the existing icon field (no backend/IPC change). Centralize the emoji-vs-image decision in a single resolveAvatarDisplay helper (agentLogo.ts) covering data-URLs, builtin avatar keys, asset URLs/paths and image file extensions, and route every avatar render site through it so a stored data-URL is never leaked as raw text: the settings AgentCard/editor preview, guid agent pills, mention dropdown, preset tag, assistant cards, the hero title, the cron task dialog, and the team selector. Previously each site duplicated its own detection and several rendered the avatar as a plain text glyph.
8c3920e to
77b59dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iconfield) as their avatar, in addition to emoji. Avatar resolution is centralized inresolveAvatarDisplay/isImageAvatar(utils/model/agentLogo.ts) and all render sites (agent cards, guid hero/pills, cron preset nodes, team selectors) now go through it.InlineAgentEditoris unified into a single clickPopoverwith a hover overlay (pencil icon). The menu offers three actions — Choose emoji, Upload image, and Reset to default (shown only when the avatar differs from the default🤖). Emoji selection reusesEmojiPickervia a newinlineprop so no nested popover is created.Test plan
🤖and appears once a custom avatar is set; clicking it restores🤖.