fix(team): resolve aionrs auto model fallback#3569
Open
DigitalNomad-Chat wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Author
|
The formatting issue has been fixed in commit The PR checks now pass for TypeScript, Oxlint, and Oxfmt. CodeQL is still pending, while the “Cancel if PR closed” workflow is skipped as expected. Please let me know if any additional changes are needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix team creation for custom Aionrs assistants whose model setting is
“remember last model” but has no remembered model yet.
Previously, the team model resolver returned
default. The backend thenpersisted
aionrsas the provider ID, causing:Provider 'aionrs' not found
The resolver now loads configured providers and selects the first enabled
model when no remembered model exists. It skips disabled providers and
providers without available models.
Related Issues
Type of Change
fix— Bug fix (non-breaking change which fixes an issue)feat— New feature (non-breaking change which adds functionality)perf— Performance improvementrefactor— Code restructuring (no behavior change)docs— Documentation updateAtomic PR Checklist (Rule 1)
<type>(<scope>): <subject>(English)Local Checks (Rule 3)
bun run format— formatting passesbun run lint— blocked by an existing invalid oxlint rule:no-await-thenablebunx tsc --noEmit— blocked by an existingbuilder-util-runtimeversion conflictbunx vitest run— full suite not runRuntime Verification
Screenshots
Not applicable. This is a backend/model-resolution behavior fix.
Additional Context
Focused test command:
pnpm exec vitest run tests/unit/renderer/teamCreateModelResolver.test.ts