fix(Picking): use full scene for rendering to buffer#2679
Open
AnthonyGlt wants to merge 1 commit intoiTowns:masterfrom
Open
fix(Picking): use full scene for rendering to buffer#2679AnthonyGlt wants to merge 1 commit intoiTowns:masterfrom
AnthonyGlt wants to merge 1 commit intoiTowns:masterfrom
Conversation
Desplandis
approved these changes
Jan 27, 2026
gchoqueux
reviewed
Jan 27, 2026
Contributor
gchoqueux
left a comment
gchoqueux
left a comment
There was a problem hiding this comment.
The depth buffer is used to pick the mesh with displacement map. In itowns there are other features to pick and filter meshes.
This fix may break the other pickings — have you checked?
Contributor
Author
|
@gchoqueux I don't get what you mean sorry. Could you provide an example of what you mean ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use the full scene for the rendering used in the picking
Motivation and Context
Currently the rendering is done with only the selected object. So there is no light associated, then the rendering is completely black.
cf #2678
The full scene includes the light. Then the
intersectis still done with only the object