Adding the ECProperty for ID in CifHydraulicAnalysis.ecschema.xml #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and Outgoing Drainage
|
|
SachBhosale
requested review from
ColinKerr,
diegoalexdiaz,
Bordoloi123 and
jonathandecarlo
and removed request for
ColinKerr and
diegoalexdiaz
|
@SachBhosale, I feel I am not the right reviewer for this schema change since I don't know the full context behind it. I suspect a review from @jonathandecarlo would be more appropriate. Feel free to reach out to me if you guys have any specific questions about the motivation behind this change & BIS. |
jonathandecarlo
approved these changes
Jan 18, 2024
|
/azp run |
|
Azure Pipelines successfully started running 6 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ECProperty for ID for Conduit Drainage, Diversion Drainage and Outgoing Drainage in CifHydraulicAnalysis.ecschema.xml.
This is to correct Bug 1254976 from iModelTechnologies project (Civil iModel Connnector).