This repository was archived by the owner on Apr 14, 2021. It is now read-only.
Safari on iOS fires wrong 'resize' events that cause the offcanvas to close itself.#84
Open
idiazroncero wants to merge 1 commit intoiamphill:masterfrom
Open
Safari on iOS fires wrong 'resize' events that cause the offcanvas to close itself.#84idiazroncero wants to merge 1 commit intoiamphill:masterfrom
idiazroncero wants to merge 1 commit intoiamphill:masterfrom
Conversation
…ize events that make the offcanavs menu to close on touchmove
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Safari/iOS, a wrong resize event is sometimes fired on touchmove (see https://stackoverflow.com/questions/8898412/iphone-ipad-triggering-unexpected-resize-events).
This causes bootstrap-offcanvas "resize" evenmt handler to fire and closes the offcanvas, even if it wasn't the purpose of the user.
This proposed solution adds a small window.width check to prevent safari/IOS from firing wrong resize events. If the resize event didn't change the width, the resize handler code won't run.