Skip to content

IBX-10414: Drop save action from forms #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

IBX-10414: Drop save action from forms #1666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
fcc1ba8
IBX-10414: Dropped save and close from ContentTypeGroup actions
ViniTou Aug 1, 2025
bf73cd5
IBX-10414: Dropped save and close from Language actions
ViniTou Aug 1, 2025
04bbe81
IBX-10414: Dropped save and close from LinkManager actions
ViniTou Aug 1, 2025
f4179a8
IBX-10414: Dropped save and close from ObjectState actions
ViniTou Aug 1, 2025
d3d94bf
IBX-10414: Dropped save and close from Role&Policy actions
ViniTou Aug 1, 2025
ffe4221
IBX-10414: Dropped save and close from Sections actions
ViniTou Aug 1, 2025
1a5b308
IBX-10414: Dropped save and close from urlWildcards actions
ViniTou Aug 1, 2025
86626f9
IBX-10414: Dropped save and close from user related actions
ViniTou Aug 1, 2025
aaa7cd2
IBX-10414: Dropped save and close from object state and section templ…
ViniTou Aug 1, 2025
45ae60e
translations
ViniTou Aug 4, 2025
6ee4a7b
dropped duplicated password change listener/builder
ViniTou Aug 4, 2025
0c2b3d4
fixed code style
ViniTou Aug 4, 2025
d3398de
removed leftover use $form in anon function calls
ViniTou Aug 4, 2025
23b2041
Adjusted behat tests
ViniTou Aug 4, 2025
c390575
fixed section update save button
ViniTou Aug 4, 2025
30702a7
adjusted section update redirect
ViniTou Aug 4, 2025
df07342
fixed section update save button v2
ViniTou Aug 4, 2025
1904f81
fixed action name for settings update
ViniTou Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/personas/ChangePassword.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Feature: Verify that an User allowed to change password can change his password
And I switch to "Account settings" tab in User settings
And I click on the change password button
And I change password from "Passw0rd-42" to "Passw0rd-43"
And I perform the "Save and close" action
And I perform the "Save" action
Then success notification that "Your password has been successfully changed." appears
And I should be on "User settings" page

Expand Down
2 changes: 1 addition & 1 deletion features/standard/Autosave.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Feature: Content Items creation
And I'm on Content view Page for root
And I go to user settings
And I disable autosave
And I perform the "Save and close" action
And I perform the "Save" action
And I'm on Content view Page for root
When I start creating a new content "Article"
And I set content fields
Expand Down
4 changes: 2 additions & 2 deletions features/standard/ContentTypeGroup.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Feature: Content type groups management
And I set fields
| label | value |
| Name | Test content type Group |
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on content type group page for "Test content type Group" group
And there're no content types for that group

Expand All @@ -50,7 +50,7 @@ Feature: Content type groups management
And I set fields
| label | value |
| Name | Test content type Group edited |
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on content type group page for "Test content type Group edited" group
And success notification that "Updated content type group 'Test content type Group'." appears

Expand Down
8 changes: 4 additions & 4 deletions features/standard/Languages.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Feature: Languages management
| label | value |
| Name | Deutsch |
| Language code | de-DE |
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on "Deutsch" Language page
And Language has proper attributes
| Name | Language code | Enabled |
Expand All @@ -39,7 +39,7 @@ Feature: Languages management
| label | value |
| Name | Deutsch Second |
| Language code | de-DE |
And I perform the "Save and close" action
And I perform the "Save" action
Then error notification that 'language with the "de-DE" language code already exists' appears

@javascript
Expand All @@ -62,7 +62,7 @@ Feature: Languages management
| label | value |
| Name | Edited Deutsch |
| Enabled | false |
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on "Edited Deutsch" Language page
And notification that "Language" "Deutsch" is updated appears
And Language has proper attributes
Expand All @@ -79,7 +79,7 @@ Feature: Languages management
And I set fields
| label | value |
| Enabled | true |
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on "Edited Deutsch" Language page
And notification that "Language" "Edited Deutsch" is updated appears
And Language has proper attributes
Expand Down
14 changes: 7 additions & 7 deletions features/standard/ObjectStates.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Feature: Object States management
| label | value |
| Name | Test Object State Group |
| Identifier | TestObjectStateGroupIdentifier |
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on "Test Object State Group" Object State group page
And "Test Object State Group" Object State group has no Object States
And Object State group has proper attributes
Expand Down Expand Up @@ -57,7 +57,7 @@ Feature: Object States management
And I set fields
| label | value |
| Name | Test Object State Group edited |
And I perform the "Save and close" action
And I perform the "Save" action
Then notification that "Object state group" "Test Object State Group edited" is updated appears
And I should be on "Test Object State Group edited" Object State group page

Expand All @@ -80,7 +80,7 @@ Feature: Object States management
And I set fields
| label | value |
| Name | Test Object State Group edited2 |
And I perform the "Save and close" action
And I perform the "Save" action
Then notification that "Object state group" "Test Object State Group edited2" is updated appears
And I should be on "Test Object State Group edited2" Object State group page

Expand All @@ -104,7 +104,7 @@ Feature: Object States management
| label | value |
| Name | Test Object State |
| Identifier | TestObjectStateIdentifier |
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on "Test Object State" Object State page
And Object State has proper attributes
| label | value |
Expand All @@ -131,7 +131,7 @@ Feature: Object States management
And I set fields
| label | value |
| Name | Test Object State edited |
And I perform the "Save and close" action
And I perform the "Save" action
Then notification that "Object state" "Test Object State edited" is updated appears
And I should be on "Test Object State edited" Object State page
And Object State has proper attributes
Expand All @@ -158,7 +158,7 @@ Feature: Object States management
And I set fields
| label | value |
| Name | Test Object State edited2 |
And I perform the "Save and close" action
And I perform the "Save" action
Then notification that "Object state" "Test Object State edited2" is updated appears
And I should be on "Test Object State edited2" Object State page
And Object State has proper attributes
Expand All @@ -174,7 +174,7 @@ Feature: Object States management
| label | value |
| Name | Test Object State 2 |
| Identifier | TestObjectStateIdentifier2 |
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on "Test Object State 2" Object State page
And Object State has proper attributes
| label | value |
Expand Down
16 changes: 8 additions & 8 deletions features/standard/Roles.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Feature: Roles management
And I set fields
| label | value |
| Name | Test Role |
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on "Test Role" Role page
And Policies list is empty
And Assignments list is empty
Expand All @@ -51,7 +51,7 @@ Feature: Roles management
And I set fields
| label | value |
| Name | Anonymous edited |
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on "Anonymous edited" Role page

@javascript
Expand Down Expand Up @@ -85,7 +85,7 @@ Feature: Roles management
| path |
| Users/Editors |
And I select limitation "Media/Images" for assignment through UDW
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on "Test Role" Role page
And Policies list is empty
And there are assignments on the "Test Role" assignments list
Expand All @@ -102,7 +102,7 @@ Feature: Roles management
And I assign groups to role
| path |
| Users |
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on "Test Role" Role page
And Policies list is empty
And there are assignments on the "Test Role" assignments list
Expand Down Expand Up @@ -146,12 +146,12 @@ Feature: Roles management
And I open "Test Role" Role page in admin SiteAccess
When I start creating a new Policy
And I select policy "Content / Read"
And I perform the "Save and close" action
And I perform the "Save" action
And success notification that "Now you can set Limitations for the Policy." appears
And I select limitation for "Content type"
| option |
| File |
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on "Test Role" Role page
And there is a policy "Content/Read" with "Content type: File" limitation on the "Test Role" policies list
And there are assignments on the "Test Role" assignments list
Expand All @@ -164,7 +164,7 @@ Feature: Roles management
And I open "Test Role" Role page in admin SiteAccess
When I start creating a new Policy
And I select policy "User / Password"
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on "Test Role" Role page
And there is a policy "User/Password" with "None" limitation on the "Test Role" policies list
And there are assignments on the "Test Role" assignments list
Expand All @@ -184,7 +184,7 @@ Feature: Roles management
And I select limitation for "State"
| option |
| Lock:Locked |
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on "Test Role" Role page
And there are policies on the "Test Role" policies list
| policy | limitation |
Expand Down
10 changes: 5 additions & 5 deletions features/standard/Sections.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ Feature: Sections management
| label | value |
| Name | Test Section |
| Identifier | TestSectionIdentifier |
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on "Test Section" Section page
And Content items list in is empty for Section
And Section has proper attributes
Expand Down Expand Up @@ -84,7 +84,7 @@ Feature: Sections management
And I set fields
| label | value |
| Name | Test Section edited |
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on "Test Section edited" Section page
And notification that "Section" "Test Section edited" is updated appears

Expand All @@ -107,7 +107,7 @@ Feature: Sections management
And I set fields
| label | value |
| Name | Test Section edited2 |
And I perform the "Save and close" action
And I perform the "Save" action
Then I should be on "Test Section edited2" Section page
And notification that "Section" "Test Section edited2" is updated appears

Expand All @@ -125,7 +125,7 @@ Feature: Sections management
| label | value |
| Name | TestSectionAssign |
| Identifier | TestSectionAssignIdentifier |
And I perform the "Save and close" action
And I perform the "Save" action
And I open "TestSectionAssign" Section page in admin SiteAccess
When I start assigning to "TestSectionAssign" Section
And I select content "Media/TestSection" through UDW
Expand Down Expand Up @@ -154,7 +154,7 @@ Feature: Sections management
| label | value |
| Name | Test Section |
| Identifier | TestSectionIdentifier2 |
And I perform the "Save and close" action
And I perform the "Save" action
And notification that "Section" "Test Section" is created appears
When I delete the section
Then notification that "Section" "Test Section" is removed appears
Expand Down
Loading
Loading