IBX-9727: Added type-hints and adapted codebase to PHP8+ for Behat-related code #1674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
force-pushed
the
introduced-type-hints-3
branch
6 times, most recently
from
4f97508 to
29467be
Compare
konradoboza
force-pushed
the
introduced-type-hints-2
branch
from
87b96df to
23383d9
Compare
konradoboza
force-pushed
the
introduced-type-hints-3
branch
2 times, most recently
from
65d7f5b to
0dd28e0
Compare
konradoboza
force-pushed
the
introduced-type-hints-3
branch
2 times, most recently
from
60e9098 to
9ceb454
Compare
konradoboza
force-pushed
the
introduced-type-hints-3
branch
from
9ceb454 to
2594ec2
Compare
|
ezrobot
requested review from
micszo,
pawlakadrian,
barbaragr,
katarzynazawada and
tomaszszopinski
and removed request for
a team
katarzynazawada
approved these changes
Aug 13, 2025
micszo
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
src/bundle#1672Description:
Regressions: ibexa/commerce#1470 ✅
Reworked Behat code to rely on strict typing and PHP8.3 syntax alongside fixing lots of PHPStan issues. Making CI green was possible thanks to invaluable @katarzynazawada assistance. 🥇
For QA:
Documentation: