-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8778: API Platform + Symfony 6 #143
Draft
adriendupuis
wants to merge
40
commits into
IBX-8921-prepare-openapi-symfony-command
Choose a base branch
from
IBX-8921-prepare-openapi-symfony-command-SF6
base: IBX-8921-prepare-openapi-symfony-command
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
IBX-8778: API Platform + Symfony 6 #143
adriendupuis
wants to merge
40
commits into
IBX-8921-prepare-openapi-symfony-command
from
IBX-8921-prepare-openapi-symfony-command-SF6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For more details see #122
For more details see https://issues.ibexa.co/browse/IBX-8596 and #116 Key changes: * Added BaseCriterionParser * Changed return type of CriterionProcessorInterface::processCriteria
For more details see #127
For more details see https://issues.ibexa.co/browse/IBX-8138 and #118 Key changes: * [Rector] Applied all Symfony 5.x rectors to the production codebase * [Rector][Tests] Applied all Symfony 5.x rectors to the test codebase * Dropped obsolete JWTUser class
For more details see https://issues.ibexa.co/browse/IBX-8726 and #123 Key changes: * Added IsBookmarked criterion * [Tests] Added IsBookmarkedTest
* [CI] Fixed Tests and codestyle * Changed not bookmarked locations count as it different across product versions
* IBX-8535: Dropped refreshSessionAction * IBX-8535: Dropped RequestParser * Dropped deprecated methods * Removed deprecated draft & publish role action * CS * regenerated baseline * removed redeclaring uriParser property * cast int to strings due to `getAttributeFromUri` typehinted return value * Dropped phpdoc for union typehint * baseline * Fixed Role Tests * Revert "IBX-8535: Dropped refreshSessionAction" This reverts commit db7dd88. * aligned deprecation version * fixed phpstan issues * publish test role * dropped non existing error * cast uri to string
…ined control of output
# Conflicts: # phpstan-baseline-8.0.neon # phpstan-baseline.neon
For more details see https://issues.ibexa.co/browse/IBX-8535 and #137 Key changes: * Dropped deprecated loadRelations usage * Replaced fake pagination with an actual one * Used new RelationListFacadeInterface contract * [Tests] Fixed unit tests
* renamed path to inputUri * Dropped removed Location::SORT_FIELD_MODIFIED_SUBNODE * replaced Criterion with interface * fix unit tests
* [Composer] Dropped obsolete ci-scripts from dev requirements * Bumped Symfony packages requirements to ^6.4 * Dropped Symfony Container dependency from REST base controller * Dropped Symfony Container dependency from Content controller * [Security] Aligned RestAuthenticator with Symfony 6 * Improved Controllers code quality * Aligned SessionController with Symfony 6 * [PHPStan] Removed resolved issues from the baseline * [Tests] Aligned VisitorTest with Symfony 6 * Fixed deprecated controller syntax in routes definitions usage * fixup! Bumped Symfony packages requirements to ^6.4 * Updated phpstan baseline * Fixed Ibexa\Tests\Rest\Server\Output\ValueObjectVisitor\RestExecutedViewTest test * Fixed Ibexa\Tests\Integration\Rest\UriParser\UriParserTest::testMatchUri test --------- Co-authored-by: Adam Wójs <[email protected]>
# Conflicts: # src/bundle/DependencyInjection/IbexaRestExtension.php # src/bundle/Resources/config/routing.yml # src/bundle/Resources/config/services.yml # src/lib/Server/Controller/Content.php # src/lib/Server/Controller/ContentType.php # src/lib/Server/Controller/Location.php # src/lib/Server/Controller/Role.php # src/lib/Server/Controller/SessionController.php # src/lib/Server/Controller/URLAlias.php # src/lib/Server/Controller/User.php
Fatal error: Type of Ibexa\Rest\Server\Controller\User\UserBaseController::$repository must be Ibexa\Contracts\Core\Repository\Repository (as in class Ibexa\Rest\Server\Controller) in /var/www/html/vendor/ibexa/rest/src/lib/Server/Controller/User/UserBaseController.php on line 28
[Symfony\Component\DependencyInjection\Exception\OutOfBoundsException] Service "ibexa.api_platform.action.entrypoint": The index "1" is not in the range [0, 0] of the arguments of class "ApiPlatform\Action\EntrypointAction". [Symfony\Component\DependencyInjection\Exception\RuntimeException] Service "ibexa.api_platform.state_provider.documentation.content_negotiation": Parent definition "api_platform.state_provider.documentation.content_negotiation" does not exist. [Symfony\Component\DependencyInjection\Exception\RuntimeException] Service "ibexa.api_platform.swagger_ui.documentation.provider": Parent definition "api_platform.swagger_ui.documentation.provider" does not exist.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
#135
Description:
For QA:
Documentation: