Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8778: API Platform + Symfony 6 #143

Draft
wants to merge 40 commits into
base: IBX-8921-prepare-openapi-symfony-command
Choose a base branch
from

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Feb 13, 2025

🎫 Issue IBX-XXXXX

Related PRs:

#135

#125

#114

Description:

For QA:

Documentation:

alongosz and others added 30 commits August 20, 2024 11:55
For more details see https://issues.ibexa.co/browse/IBX-8596 and #116

Key changes:

* Added BaseCriterionParser

* Changed return type of CriterionProcessorInterface::processCriteria
For more details see https://issues.ibexa.co/browse/IBX-8138 and #118

Key changes:

* [Rector] Applied all Symfony 5.x rectors to the production codebase

* [Rector][Tests] Applied all Symfony 5.x rectors to the test codebase

* Dropped obsolete JWTUser class
For more details see https://issues.ibexa.co/browse/IBX-8726 and #123

Key changes:

* Added IsBookmarked criterion

* [Tests] Added IsBookmarkedTest
* [CI] Fixed Tests and codestyle

* Changed not bookmarked locations count as it different across product versions
…ts method (#134)

* IBX-8534: Dropped usage of deprecated contentService::loadContentDrafts method

* Fixed phpstan issues
* IBX-8535: Dropped refreshSessionAction

* IBX-8535: Dropped RequestParser

* Dropped deprecated methods

* Removed deprecated draft & publish role action

* CS

* regenerated baseline

* removed redeclaring uriParser property

* cast int to strings due to `getAttributeFromUri` typehinted return value

* Dropped phpdoc for union typehint

* baseline

* Fixed Role Tests

* Revert "IBX-8535: Dropped refreshSessionAction"

This reverts commit db7dd88.

* aligned deprecation version

* fixed phpstan issues

* publish test role

* dropped non existing error

* cast uri to string
# Conflicts:
#	phpstan-baseline-8.0.neon
#	phpstan-baseline.neon
For more details see https://issues.ibexa.co/browse/IBX-8535 and #137

Key changes:

* Dropped deprecated loadRelations usage

* Replaced fake pagination with an actual one

* Used new RelationListFacadeInterface contract

* [Tests] Fixed unit tests
* renamed path to inputUri

* Dropped removed Location::SORT_FIELD_MODIFIED_SUBNODE

* replaced Criterion with interface

* fix unit tests
adamwojs and others added 10 commits December 27, 2024 08:20
* [Composer] Dropped obsolete ci-scripts from dev requirements
* Bumped Symfony packages requirements to ^6.4
* Dropped Symfony Container dependency from REST base controller
* Dropped Symfony Container dependency from Content controller
* [Security] Aligned RestAuthenticator with Symfony 6
* Improved Controllers code quality
* Aligned SessionController with Symfony 6
* [PHPStan] Removed resolved issues from the baseline
* [Tests] Aligned VisitorTest with Symfony 6
* Fixed deprecated controller syntax in routes definitions usage
* fixup! Bumped Symfony packages requirements to ^6.4
* Updated phpstan baseline
* Fixed Ibexa\Tests\Rest\Server\Output\ValueObjectVisitor\RestExecutedViewTest test
* Fixed Ibexa\Tests\Integration\Rest\UriParser\UriParserTest::testMatchUri test

---------

Co-authored-by: Adam Wójs <[email protected]>
# Conflicts:
#	src/bundle/DependencyInjection/IbexaRestExtension.php
#	src/bundle/Resources/config/routing.yml
#	src/bundle/Resources/config/services.yml
#	src/lib/Server/Controller/Content.php
#	src/lib/Server/Controller/ContentType.php
#	src/lib/Server/Controller/Location.php
#	src/lib/Server/Controller/Role.php
#	src/lib/Server/Controller/SessionController.php
#	src/lib/Server/Controller/URLAlias.php
#	src/lib/Server/Controller/User.php
Fatal error: Type of Ibexa\Rest\Server\Controller\User\UserBaseController::$repository must be Ibexa\Contracts\Core\Repository\Repository (as in class Ibexa\Rest\Server\Controller) in /var/www/html/vendor/ibexa/rest/src/lib/Server/Controller/User/UserBaseController.php on line 28
  [Symfony\Component\DependencyInjection\Exception\OutOfBoundsException]
  Service "ibexa.api_platform.action.entrypoint": The index "1" is not in the range [0, 0] of the arguments of class "ApiPlatform\Action\EntrypointAction".

  [Symfony\Component\DependencyInjection\Exception\RuntimeException]
  Service "ibexa.api_platform.state_provider.documentation.content_negotiation": Parent definition "api_platform.state_provider.documentation.content_negotiation" does not exist.

  [Symfony\Component\DependencyInjection\Exception\RuntimeException]
  Service "ibexa.api_platform.swagger_ui.documentation.provider": Parent definition "api_platform.swagger_ui.documentation.provider" does not exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants