Skip to content

fix: remove kafka 4 incompatible message from readme #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025

Conversation

Joel-hanson
Copy link
Contributor

This pull request makes a minor documentation update by removing an outdated statement about Kafka version support from the README.md.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@thajinushehin thajinushehin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Joel-hanson Joel-hanson changed the title fix: remove kafka 4 compatible message from readme fix: remove kafka 4 incompatible message from readme Aug 13, 2025
@Joel-hanson Joel-hanson merged commit ef7f9bb into ibm-messaging:main Aug 13, 2025
2 checks passed
@Joel-hanson Joel-hanson deleted the remove-verison-issue branch August 13, 2025 07:05
@dalelane
Copy link
Contributor

@Joel-hanson @thajinushehin FYI - this would have been better tagged as a "docs" commit. "fix" is used to identify a bug fix, but no bugs were fixed here.

Typical conventional commit types are:

  • feat: Introduces a new feature.
  • fix: Patches a bug.
  • docs: Documentation-only changes.
  • style: Changes that do not affect the meaning of the code (white-space, formatting, etc).
  • refactor: A code change that neither fixes a bug nor adds a feature.
  • perf: Improves performance.
  • test: Adds missing tests or corrects existing tests.
  • chore: Changes to the build process or auxiliary tools and libraries such as documentation generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants