Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPD:Add DefaultError entry in PEL registry #84

Open
wants to merge 2 commits into
base: 1110
Choose a base branch
from

Conversation

PriyangaRamasamy
Copy link
Contributor

This commit adds com.ibm.VPD.Error.DefaultError interface definition in the PEL's message registry JSON. This can be used to log unknown VPD errors.

Copy link

@jinuthomas jinuthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why you need default for VPD , there should be a general one

Signed-off-by: Priyanga Ramasamy <[email protected]>
This commit adds com.ibm.VPD.Error.DefaultError interface definition
in the PEL's message registry JSON. This can be used to log unknown VPD
errors.

Signed-off-by: Priyanga Ramasamy <[email protected]>
@PriyangaRamasamy
Copy link
Contributor Author

why you need default for VPD , there should be a general one

we have a general one xyz.openbmc_project.Logging.Error.Default, but it's subsystem says n/a <here> This is used by phosphor-logging when the user given error type is not present in message_registry.json

com.ibm.VPD.Error.DefaultError says that the subsystem is VPD and can be logged only by VPD to capture unknown errors.

@PriyangaRamasamy PriyangaRamasamy force-pushed the vpd-default-error-registry branch from 9c10abb to 91ae40d Compare February 5, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants