Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ported changes from Buildings for CDL.Logica.TrueFalseHold #1967

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ported changes from Buildings for CDL.Logica.TrueFalseHold #1967

wants to merge 1 commit into from

Conversation

mwetter
Copy link
Contributor

@mwetter mwetter commented Feb 10, 2025

This closes #1966

@mwetter mwetter requested a review from FWuellhorst February 12, 2025 23:38
FWuellhorst
FWuellhorst approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@FWuellhorst FWuellhorst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, but I am wondering if a documentation warning or similar should be raised if users use cvode with dymola < 2025x or other tools. Or is this irrelevant as the bug error is not present in cvode in OM or FMU-export?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FWuellhorst FWuellhorst FWuellhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate changes to TrueFalseHold
2 participants
@mwetter @FWuellhorst