This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Swap twitter card default in base.html to summary card type#260
Open
andrewserong wants to merge 1 commit intoic-labs:developfrom
Open
Swap twitter card default in base.html to summary card type#260andrewserong wants to merge 1 commit intoic-labs:developfrom
andrewserong wants to merge 1 commit intoic-labs:developfrom
Conversation
The summary Twitter card type is possibly a better default card type as it uses a square thumbnail, so will work with a larger variety of images.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've done a bit of work recently at ACMI on getting Twitter cards to work nicely. This PR is to swap the default card type to a Summary card type, which is possibly a better default type as it uses square thumbnails so might be a better crop for most images. I'd recommend using this as a default in the icekit repo, and have orgs override it if they'd prefer a different card type.