Generate drift tables

[ikbendewilliam]

No description provided.

[NicolaVerbeeck]

It should be specified that custom converters are not supported for drift (unless we add support for them)

[vanlooverenkoen]

Not sure if all the test cover all cases. We should maybe create a list of edgecases and check if the tests are covering those edge cases as well

[vanlooverenkoen]

Maybe we should also indicate why it should throw here?

[vanlooverenkoen]

generate_drift_table ignore_for_table I would use ignore_for_drift_table here as well.

[vanlooverenkoen]

 authors is an array or map. Ignore this field by adding ignore_for_table: true

improve error handling.

`authors` is an "array or maps", this is not support to save in a table. You can ignore this field by adding

   ignore_for_table: true

Also, specify if it is a map or array. We already know this.

[vanlooverenkoen]

There is no error thrown when I create a table. without a primary key.
Maybe we don't need an error, but we should probably log this.

[vanlooverenkoen]

Question: what happens if we want to add an extra field that is not returned from the API? And we don't want to be creating an extra table, and add complexity of doing a lookup in that extra table?

[vanlooverenkoen]

When using a type: custom we should allow to specify a TypeConverter. Right now it just said, No drift column or type for Duration but duration could be mapped to the amount of seconds or miliseconds.

[vanlooverenkoen]

Tables generate 1 enter to much. after all columns

[vanlooverenkoen]

A generated table imports

import 'package:flutter/foundation.dart';

but it is never needed.

config

Book2:
  path: book/
  generate_drift_table: true
  properties:
    id:
      type: int
      required: true
      is_table_primary_key: true
    name: string

[vanlooverenkoen]

There is 1 big bug I thinks with enums.

This is the config

    secondCategory: BookCategory?

This is generated.

class BookTableBookCategoryConverter extends TypeConverter<BookCategory, String> {
  const BookTableBookCategoryConverter();

  @override
  BookCategory fromSql(String fromDb) {
    for (final value in BookCategory.values) {
      if (value.jsonValue == fromDb) return value;
    }
    return BookCategory.values.first;
  }

  @override
  String toSql(BookCategory value) {
    return value.jsonValue;
  }
}

I would expect the BookCategory in the BookTableBookCategoryConverter to be nullable. Becuase right now you just return the first item. Which will result in incorrectly saved values.

[ikbendewilliam]

A generated table imports

import 'package:flutter/foundation.dart';

but it is never needed.

config

Book2:
  path: book/
  generate_drift_table: true
  properties:
    id:
      type: int
      required: true
      is_table_primary_key: true
    name: string

Note that this is added in the config in pubspec.yaml

  extra_imports:
    - 'package:flutter/foundation.dart'

[ikbendewilliam]

Question: what happens if we want to add an extra field that is not returned from the API? And we don't want to be creating an extra table, and add complexity of doing a lookup in that extra table?

I'll add only_for_table for this

[ikbendewilliam]

When using a type: custom we should allow to specify a TypeConverter. Right now it just said, No drift column or type for Duration but duration could be mapped to the amount of seconds or miliseconds.

I've added extra_imports_for_table and type_converter_for_table for this

[ikbendewilliam]

Added a nullable enum converter for non-required fields

[vanlooverenkoen]

Decline for now. Can be revisited in the future