Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enum map and extension #133

Merged
merged 6 commits into from
Mar 8, 2023
Merged

Fix enum map and extension #133

merged 6 commits into from
Mar 8, 2023

Conversation

luca-vz
Copy link

@luca-vz luca-vz commented Mar 7, 2023 •
edited
Loading

Generating enums with an itemType int/double created maps and extensions where the itemType was still a String, this has been changed. Besides that the name of xMapping of an enum was first generated as XMapping and is now getting generated correctly (xMapping).

@ikbendewilliam
Copy link
Contributor

Next time add an issue with the details of what went wrong

@ikbendewilliam
Copy link
Contributor

LGTM
Sidenote, create a new issue for the deprecated lint rule and ignore field

   info • 'invariant_booleans' is a deprecated lint rule and should not be used
          • example/analysis_options.yaml:58:7 • deprecated_lint_hint
   info • 'ignore' is deprecated and shouldn't be used. Use `includeFromJson`
          and `includeToJson` with a value of `false` instead •
          example/lib/model/user/testing.dart:13:55 • deprecated_member_use

vanlooverenkoen
vanlooverenkoen suggested changes Mar 8, 2023
View reviewed changes
lib/util/case_util.dart Outdated

String get camelCase => _getCamelCase();
String get upperCamelCase => _getUpperCamelCase();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no such thing as upperCamelCase. This is just PascalCase

@vanlooverenkoen
Copy link
Contributor

Ticket created for the ignore: #134

@vanlooverenkoen vanlooverenkoen merged commit 95c36ad into master Mar 8, 2023
@vanlooverenkoen vanlooverenkoen deleted the fix-enum-map-and-extension branch March 8, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanlooverenkoen vanlooverenkoen vanlooverenkoen requested changes

@jorre127 jorre127 Awaiting requested review from jorre127

@ikbendewilliam ikbendewilliam Awaiting requested review from ikbendewilliam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luca-vz @ikbendewilliam @vanlooverenkoen