Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#134 Removed the ignore #137

Merged
merged 3 commits into from
Jun 5, 2023
Merged

#134 Removed the ignore #137

merged 3 commits into from
Jun 5, 2023

Conversation

vanlooverenkoen
Copy link
Contributor

Fixed #134

HannesVDB
HannesVDB approved these changes Jun 5, 2023
View reviewed changes
Copy link

@HannesVDB HannesVDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok! Only update the docs.

@vanlooverenkoen vanlooverenkoen merged commit 461bac9 into master Jun 5, 2023
@vanlooverenkoen vanlooverenkoen deleted the refactor/#134-remove-ignore branch June 5, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HannesVDB HannesVDB HannesVDB approved these changes

@ikbendewilliam ikbendewilliam Awaiting requested review from ikbendewilliam

@jorre127 jorre127 Awaiting requested review from jorre127

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ignore should not be used anymore. (Deprecated)
2 participants
@vanlooverenkoen @HannesVDB