Skip to content

Commit

Permalink
CI: Add crucial build-local step to dockerfile
Browse files Browse the repository at this point in the history
  • Loading branch information
Gum-Joe committed Oct 18, 2024
1 parent e02e3d7 commit bda02f3
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 7 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/collection.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,10 @@ jobs:
run: npx nx affected -t test

build-and-push-collection-image:
needs:
- build
- lint
- test
# needs:
# - build
# - lint
# - test
# if: github.ref == 'refs/heads/main'
runs-on: ubuntu-latest
permissions:
Expand Down
1 change: 1 addition & 0 deletions collection/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ COPY jest* .
COPY tsconfig.base.json tsconfig.base.json
COPY collection collection
COPY common common
RUN npx nx run-many -t build-local
RUN npx nx run collection:prisma-generate
RUN npx nx run collection:build

Expand Down
3 changes: 2 additions & 1 deletion collection/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ Other tools have their own package.jsons as that was how they were originally se
1. From the root of the repo run `npm install`
2. Copy `.env.local.template` to `.env.local` and fill in the details
3. Run from this dir `npx nx prisma-push` to create the database
4. Run from this dir `npx nx dev` to start the dev server
4. Run `npx nx run-many -t build-local` to build required monorepo libraries
5. Run from this dir `npx nx dev` to start the dev server

## Docker

Expand Down
11 changes: 9 additions & 2 deletions common/eactivities/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
{
"name": "@docsoc/eactivities",
"version": "1.2.1",
"publishConfig": {
"access": "public"
},
"dependencies": {
"@types/axios": "^0.14.0",
"axios": "^1.7.3",
Expand All @@ -11,5 +14,9 @@
},
"type": "module",
"main": "./dist/index.js",
"typings": "./dist/index.d.ts"
}
"typings": "./dist/index.d.ts",
"exports": {
"./package.json": "./package.json",
".": "./dist/index.js"
}
}

0 comments on commit bda02f3

Please sign in to comment.