Sort CombinerMG input mesh to avert error #29853
Open
+27
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job Documentation, step Docs: sync website on 7b33fca wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage, step Generate coverage on 7b33fca wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
miaoyinb
requested review from
lindsayad,
roystgnr and
GiudGiud
as code owners
|
I would rather not do that as the boundary & subdomain name /id deconfliction relies on the order of the input meshes (for its id assignments). The number of elements is not as good a criterion for ordering as the parameter order the right fix is likely in LibMesh here |
|
I agree that fixing it in libMesh makes more sense. |
lindsayad
reviewed
Feb 11, 2025
Comment on lines
+141
to
+143
| // Sort the _meshes by the number of elements so that we start with the largest input mesh | ||
| // calling libMesh's copy_nodes_and_elements() in distributed mesh mode with the destination | ||
| // mesh with only one element and big source mesh leads to a crash |
There was a problem hiding this comment.
Thanks, @lindsayad and @roystgnr
I also opened a libMesh issue for this libMesh/libmesh#4075
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #29843