Skip to content

user: 프론트 이메일 인증 리다이렉트 주소 변경#37

Merged
ZaMan0806 merged 2 commits into
developfrom
hotfix/email
Dec 27, 2025
Merged

user: 프론트 이메일 인증 리다이렉트 주소 변경#37
ZaMan0806 merged 2 commits into
developfrom
hotfix/email

Conversation

@ZaMan0806

Copy link
Copy Markdown
Collaborator

개요

이메일 인증 버튼의 리다이렉트 주소를 변경하였습니다.

@ZaMan0806 ZaMan0806 requested a review from hongjm0912 December 27, 2025 10:09
@ZaMan0806 ZaMan0806 self-assigned this Dec 27, 2025
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @ZaMan-O, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 풀 리퀘스트는 이메일 인증 과정에서 사용되는 리다이렉트 주소의 구성 방식을 변경합니다. 기존의 고정된 경로 대신, 더 유연하게 URL을 생성하도록 하여, 인증 버튼 클릭 시 사용자를 올바른 목적지로 안내하는 방식을 개선합니다.

Highlights

  • 이메일 인증 URL 변경: SendEmailService.java 파일에서 이메일 인증을 위한 리다이렉트 URL 생성 로직이 변경되었습니다.
  • URL 구성 간소화: 기존에 "/api/v1/auth/verify?token="으로 하드코딩되어 있던 경로가 제거되고, token이 url 변수에 직접 추가되도록 수정되었습니다. 이는 url 변수가 이미 완전한 리다이렉트 경로를 포함할 것으로 예상됩니다.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

안녕하세요. 이메일 인증 리다이렉트 주소를 변경하는 PR을 리뷰했습니다.

인증 URL 생성 로직을 프론트엔드 주소로 변경하신 것을 확인했습니다. 다만, 현재 구현은 base.url 프로퍼티에 특정 경로와 쿼리 파라미터 키까지 포함하도록 강제하여 설정이 깨지기 쉬운 구조가 될 수 있습니다.

이에 대해 코드의 안정성과 명확성을 높일 수 있는 제안을 리뷰 코멘트로 남겼습니다. 확인 부탁드립니다.

Comment thread src/main/java/org/example/story/domain/user/service/SendEmailService.java Outdated
@ZaMan0806 ZaMan0806 merged commit 005b516 into develop Dec 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants