[refactor] replace React Bootstrap with MUI to optimize UX #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[polish] MainNavigator, ColorModeDropdown [config] tailwind, eslint, postcss [migrate] replace bootstrap with material-ui within components [fix] dark mode flicker
[polish] partner logo for dark mode
[polish] project, member card layout [fix] project card languages logo missing [unfinshed] member, project detail
wangrunlin
approved these changes
Oct 14, 2024
|
这个 PR 内容好多，不过 Vercel 部署似乎失败了，我用在线环境看下效果。 |
确实是有问题的，直接跑 dev 跑不起来，可能整体环境还有些问题，或者需要环境变量。 |
是的，pnpm build 没通过，我有些 detail 页面还没改完，有报错，稍等哈~ |
TechQuery
requested changes
Oct 14, 2024
Comment on lines
+47
to
+51
| <div className=""> | ||
| <MemberCard className="sticky-top" style={{ top: '6.5rem' }} {...member} /> | ||
| </div> | ||
| <div className=""> | ||
| <Tabs className=""> |
There was a problem hiding this comment.
Suggested change
| <div className=""> | |
| <MemberCard className="sticky-top" style={{ top: '6.5rem' }} {...member} /> | |
| </div> | |
| <div className=""> | |
| <Tabs className=""> | |
| <MemberCard className="sticky-top" style={{ top: '6.5rem' }} {...member} /> | |
| <Tabs> |
pages/member/[nickname].tsx
Outdated
| </Row> | ||
| </Container> | ||
| ), | ||
| <div role='tabpanel'></div> |
TechQuery
requested changes
Oct 14, 2024
Comment on lines
+76
to
+89
| 50: 'var(--mui-palette-grey-50)', | ||
| 100: 'var(--mui-palette-grey-100)', | ||
| 200: 'var(--mui-palette-grey-200)', | ||
| 300: 'var(--mui-palette-grey-300)', | ||
| 400: 'var(--mui-palette-grey-400)', | ||
| 500: 'var(--mui-palette-grey-500)', | ||
| 600: 'var(--mui-palette-grey-600)', | ||
| 700: 'var(--mui-palette-grey-700)', | ||
| 800: 'var(--mui-palette-grey-800)', | ||
| 900: 'var(--mui-palette-grey-900)', | ||
| A100: 'var(--mui-palette-grey-A100)', | ||
| A200: 'var(--mui-palette-grey-A200)', | ||
| A400: 'var(--mui-palette-grey-A400)', | ||
| A700: 'var(--mui-palette-grey-A700)' |
There was a problem hiding this comment.
既然是 JS 配置文件，类似大片有规律的配置直接用 [].map() 迭代出来吧。
There was a problem hiding this comment.
你可以提 issue，我不会在这个 PR 改
[fix] type error of lifecycle method [polish] review details
TechQuery
requested changes
Oct 15, 2024
pages/index.tsx
Outdated
Comment on lines
31
to
28
| new GitRepositoryModel('idea2app').getList({}, 1, 9), | ||
| new GitRepositoryModel('idea2app').getList({ relation: [] }, 1, 9), |
There was a problem hiding this comment.
以前配置的不严格，限制的插件规则更严格一些，next 关于插件配置文档不够清晰，他都是推荐用自己的
我翻插件官方文档配的https://typescript-eslint.io/getting-started/legacy-eslint-setup#additional-configs
我把这两行删了吧
'eslint:recommended',
-'plugin:@typescript-eslint/strict',
-'plugin:@typescript-eslint/stylistic'There was a problem hiding this comment.
类型“{}”的参数不能赋给类型“RepositoryFilter”的参数。
类型 "{}" 中缺少属性 "relation"，但类型 "RepositoryFilter" 中需要该属性。ts(2345)
There was a problem hiding this comment.
类型“{}”的参数不能赋给类型“RepositoryFilter”的参数。 类型 "{}" 中缺少属性 "relation"，但类型 "RepositoryFilter" 中需要该属性。ts(2345)
把上游库字段改成可选的就行了：https://github.com/idea2app/MobX-GitHub/blob/6cc83bcee84023d2116729b49e5b11fb1e5c8cbe/source/Repository.ts#L29-L31
[remove] ul with nav in MainNavigator [fix] typescript eslint strict mode
TechQuery
requested changes
Oct 15, 2024
TechQuery
changed the title
TechQuery
requested changes
Oct 16, 2024
[optimize] reduce Dependency size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[add] darkmode
[polish] MainNavigator, ColorModeDropdown
[config] tailwind, eslint, postcss
[migrate] replace bootstrap with material-ui within components [fix] dark mode flicker
Checklist（清单）: