Skip to content

Commit

Permalink
[CRAN] Add trailing slashes for URLs
Browse files Browse the repository at this point in the history
  • Loading branch information
Hongyuan Jia committed Aug 11, 2020
1 parent e5042e4 commit 182e119
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 11 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Authors@R: c(
Description:
Query, download climate change projection data from the 'CMIP6' (Coupled
Model Intercomparison Project Phase 6) project
<https://pcmdi.llnl.gov/CMIP6> in the 'ESGF' (Earth System Grid Federation)
<https://pcmdi.llnl.gov/CMIP6/> in the 'ESGF' (Earth System Grid Federation)
platform <https://esgf.llnl.gov>, and create future 'EnergyPlus'
<https://energyplus.net> Weather ('EPW') files adjusted from climate changes
using data from Global Climate Models ('GCM').
Expand Down
2 changes: 1 addition & 1 deletion R/epwshiftr-package.R
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#' epwshiftr: Create future EnergyPlus Weather files using CMIP6 data
#'
#' Query, download climate change projection data from the [CMIP6 (Coupled Model
#' Intercomparison Project Phase 6) project](https://pcmdi.llnl.gov/CMIP6) in
#' Intercomparison Project Phase 6) project](https://pcmdi.llnl.gov/CMIP6/) in
#' the [ESGF (Earth System Grid Federation) platform](https://esgf.llnl.gov),
#' and create future [EnergyPlus](https://energyplus.net) Weather (EPW) files
#' adjusted from climate changes using data from Global Climate Models (GCM).
Expand Down
2 changes: 1 addition & 1 deletion README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ Hongyuan Jia and Adrian Chong
> licensing restrictions, which are recorded in each file as a global
> attribute (named “license”).
>
> Please carefully read and adhere to the [CMIP6 Terms of Use](https://pcmdi.llnl.gov/CMIP6/TermsOfUse).
> Please carefully read and adhere to the [CMIP6 Terms of Use](https://pcmdi.llnl.gov/CMIP6/TermsOfUse/).
## Contribute

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ Hongyuan Jia and Adrian Chong
> are recorded in each file as a global attribute (named “license”).
>
> Please carefully read and adhere to the [CMIP6 Terms of
> Use](https://pcmdi.llnl.gov/CMIP6/TermsOfUse).
> Use](https://pcmdi.llnl.gov/CMIP6/TermsOfUse/).
## Contribute

Expand Down
23 changes: 17 additions & 6 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,24 @@
Comments from CRAN maintainer:

```
'Packages which use Internet resources should fail gracefully with an
informative message if the resource is not available or has changed (and
not give a check warning nor error).'
Found the following (possibly) invalid URLs:
URL: https://pcmdi.llnl.gov/CMIP6 (moved to
https://pcmdi.llnl.gov/CMIP6/)
From: DESCRIPTION
man/epwshiftr-package.Rd
Status: 200
Message: OK
URL: https://pcmdi.llnl.gov/CMIP6/TermsOfUse (moved to
https://pcmdi.llnl.gov/CMIP6/TermsOfUse/)
From: README.md
Status: 200
Message: OK
-> trailing slashes, please.
Please fix and resubmit.
```

Revisions:

* I added an informative message when the resource is not available.
* I updated tests accordingly to run certain tests only when the resource is
available.
* I have revised corresponding files to add trailing slashes.
2 changes: 1 addition & 1 deletion man/epwshiftr-package.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 182e119

Please sign in to comment.