Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Collisionless heat flux into the Braginskii module #317

Merged
merged 16 commits into from
Feb 17, 2025

Conversation

vreville
Copy link

@vreville vreville commented Jan 20, 2025

This PR adds an option to the bragTDiffusion module. A new keyword is set to either nosat or wcless. With the latter, the heat flux is a combination of the Braginskii heat flux and a collisionless heat flux \propto p v (where p is the thermal fluid pressure and v the bulk velocity). The transition from the Braginskii to the collisionless form is handled through a third parameter alpha (typically an array that depends on the coordinates or the density) while the amplitude of the collisionless heat flux is controlled by a fourth parameter beta, usually constant but can be userdef.

A test and 1D example is given in test/MHD/clessTDiffusion/.
bragTDiffusion tests have been updated to include the new option.

@glesur glesur self-requested a review January 21, 2025 16:18
@vreville
Copy link
Author

Hum, it looks like the non regression tests from the FargoMHDspherical is trying to compare 16x16x128 cubes with 16x16x64 cubes. I did not touch this file, is this expected ?

Copy link
Contributor

@glesur glesur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, except for the userdef function signature which would benefit from using a single std::vector<IdefixArray3D> as parameter for all of the implementations.

Copy link
Contributor

@glesur glesur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, just change std::vector[] by std::vector.at() and we're good to go

@glesur glesur merged commit f87b698 into idefix-code:develop Feb 17, 2025
38 checks passed
@vreville vreville deleted the CollisionlessTC branch February 17, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants