fix RKL in grids with small spacing #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with small grid spacing (<1e-5)
-properly handles curvature on Bphi in 2.5D spherical with RKL
of the EMF component when axisymmetric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a bug that could lead to Nans when using the RKL scheme on grids with small grid spacing (<1e-5) as discussed in #322
additionally correct the curvature terms on cell-centered B that were not properly taken into account in the RKL loop. This can affect the outcome of simulations using the RKL scheme for Ohmic or Ambipolar diffusion in 2.5D non-cartesian models (NB: full 3D models are not affected since B is entirely computed by the CT scheme in these cases)