Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the custom SHA-256 implementation with the noble-hashes library, simplifying the codebase by removing ~250 lines of custom cryptographic code in favor of a well-established, audited library.
- Replaces custom SHA-256 implementation with
@noble/hashes/sha2 - Removes the
Hashclass export since it's no longer available - Maintains the same
sha256function interface for backward compatibility
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/sha256.ts | Removes entire custom SHA-256 implementation and replaces with noble-hashes import |
| src/index.ts | Removes Hash class from exports since it's no longer available |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
vmidyllic
approved these changes
Oct 6, 2025
Kolezhniuk
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove custom SHA-256 implementation and replace with noble-hashes