Skip to content

Switch to noble-hashes#27

Merged
daveroga merged 5 commits intomainfrom
PID-3513-switch-sha256-noble-hashes
Oct 6, 2025
Merged

Switch to noble-hashes#27
daveroga merged 5 commits intomainfrom
PID-3513-switch-sha256-noble-hashes

Conversation

@daveroga
Copy link
Contributor

@daveroga daveroga commented Oct 2, 2025

Remove custom SHA-256 implementation and replace with noble-hashes

@daveroga daveroga requested review from Kolezhniuk, OBrezhniev and Copilot and removed request for Kolezhniuk October 2, 2025 09:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the custom SHA-256 implementation with the noble-hashes library, simplifying the codebase by removing ~250 lines of custom cryptographic code in favor of a well-established, audited library.

  • Replaces custom SHA-256 implementation with @noble/hashes/sha2
  • Removes the Hash class export since it's no longer available
  • Maintains the same sha256 function interface for backward compatibility

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/sha256.ts Removes entire custom SHA-256 implementation and replaces with noble-hashes import
src/index.ts Removes Hash class from exports since it's no longer available

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@daveroga daveroga requested a review from vmidyllic October 6, 2025 07:44
@daveroga daveroga merged commit 51923de into main Oct 6, 2025
2 checks passed
@daveroga daveroga deleted the PID-3513-switch-sha256-noble-hashes branch October 6, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants