Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exceptions #5

Merged
merged 7 commits into from
Feb 6, 2024
Merged

Exceptions #5

merged 7 commits into from
Feb 6, 2024

Conversation

OBrezhniev
Copy link
Member

@OBrezhniev OBrezhniev commented Dec 27, 2023 •
edited
Loading

Switch from asserts to exceptions

TODO:

  • Test performance impact

@OBrezhniev OBrezhniev requested review from olomix and demonsh December 27, 2023 17:21
@OBrezhniev
Copy link
Member Author

Tested performance. No measurable perf impact present.

@OBrezhniev OBrezhniev requested a review from nixw4 January 13, 2024 01:59
olomix
olomix reviewed Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@olomix olomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this code is part of #10 and PR should be closed.

@OBrezhniev OBrezhniev merged commit 18a17de into main Feb 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olomix olomix olomix left review comments

@demonsh demonsh Awaiting requested review from demonsh

@nixw4 nixw4 Awaiting requested review from nixw4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OBrezhniev @olomix