Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds extension point to validity-map #164

Open
wants to merge 51 commits into
base: main
Choose a base branch
from
Open

Conversation

nedmsmith
Copy link
Collaborator

Adds extension point to validity-map

Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nedmsmith nedmsmith self-assigned this Oct 12, 2023
Copy link
Collaborator

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The semantics of this must be documented in §1.3.3 -- and possibly in all the places it is validity-map is reused.

Besides, since this introduces an extension point, we need a new IANA sub-registry.

But more generally, I don't think this is the right design. (See #161 (comment) for the rationale.)

@henkbirkholz
Copy link
Member

I am a bit confused by this PR (next to style & syntax).

This seems to break the straight forward semantics of current validity map. But more importantly, I cannot see how Epoch Markers (that were the example in #161 would solve a problem here. Do they really?

@nedmsmith
Copy link
Collaborator Author

I am a bit confused by this PR (next to style & syntax).

This seems to break the straight forward semantics of current validity map. But more importantly, I cannot see how Epoch Markers (that were the example in #161 would solve a problem here. Do they really?

The validity period assumes verifier has trusted time. I'm looking for a solution that doesn't require trusted time. Epoch markers could be used in this sort of environment.

henkbirkholz and others added 10 commits December 1, 2023 13:57
Co-authored-by: Thomas Fossati <[email protected]>
Signed-off-by: Thomas Fossati <[email protected]>
Co-authored-by: Thomas Fossati <[email protected]>
Co-authored-by: Henk Birkholz <[email protected]>
Signed-off-by: Thomas Fossati <[email protected]>
Co-authored-by: Thomas Fossati <[email protected]>
Co-authored-by: Henk Birkholz <[email protected]>
Signed-off-by: Thomas Fossati <[email protected]>
Copy link
Collaborator

@andrew-draper andrew-draper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I think it also needs text which says that if a verifier doesn't understand any of the fields within validity-map then that map is not valid.

Improved prose and added lines describing verifier behavior
Adds extension point to validity-map
Improved prose and added lines describing verifier behavior
@nedmsmith
Copy link
Collaborator Author

nedmsmith commented Jan 19, 2024

This branch was rebased to pick up changes in main that fixes ghpages build errors.

@nedmsmith nedmsmith changed the title Fix issue #161 Adds extension point to validity-map Jan 19, 2024
@nedmsmith
Copy link
Collaborator Author

Besides, since this introduces an extension point, we need a new IANA sub-registry.

We can tolerate not having an IANA sub-registry until there is interest in standardizing extensions. In the meantime, a vendor may leverage a profile context to define a vendor-specific approach using negative code points.

The lack of a defined registry creates a friction point that limits use of the extention point for standard use, thereby limiting possible backwards compatibility issues should another approach become preferred.

@nedmsmith
Copy link
Collaborator Author

Move to "won't fix" based on the justification that an alternative form of validity can be added by extending at the corim-map and opting not to use validity?

@nedmsmith nedmsmith added the wontfix This will not be worked on label Apr 26, 2024
@deeglaze
Copy link
Collaborator

Sgrm

@yogeshbdeshpande
Copy link
Collaborator

Awaiting some actions in EPOCH markers draft to introduce an Extensibility points. @henk to follow up on this and then only close this Pull Request!

@henkbirkholz henkbirkholz self-assigned this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants