Add better description of tag and CoMID/CoSWID tags #378
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yogesh Deshpande <[email protected]>
yogeshbdeshpande
requested review from
henkbirkholz,
thomas-fossati and
nedmsmith
as code owners
deeglaze
reviewed
Feb 13, 2025
deeglaze
reviewed
Feb 13, 2025
Added Dionna's correction! Co-authored-by: Dionna Amalie Glaze <[email protected]>
|
@thomas-fossati , @henkbirkholz please provide your review prior to the meeting, to speed up please! |
| @@ -542,7 +541,7 @@ Described in {{sec-common-validity}}. | |||
|
|
|||
| # Concise Module Identifier (CoMID) {#sec-comid} | |||
|
|
|||
| A CoMID tag contains information about hardware, firmware, or module composition. | |||
| A CoMID tag contains claims and metadata about hardware, firmware, or module composition. | |||
There was a problem hiding this comment.
not sure what "metadata" adds on top of "claims"
Suggested change
| A CoMID tag contains claims and metadata about hardware, firmware, or module composition. | |
| A CoMID tag contains claims about hardware, firmware, or module composition. |
There was a problem hiding this comment.
The claims are encoded in a measurement values map, but metadata about the claims include items like entities and linked-tags
There was a problem hiding this comment.
The metadata is about the CoMID itself rather than "HW, FW or module composition."
There was a problem hiding this comment.
Also we have claims inside measurement-values-map and mkey can contain some additional information about the claim, like measurement identifier and extensible objects about claims!
Thomas's Part of the review comments addressed Co-authored-by: Thomas Fossati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of Issue #195