Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge glossaries #389

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

merge glossaries #389

wants to merge 7 commits into from

Conversation

thomas-fossati
Copy link
Collaborator

Fix #385

Note: I've only merged §8.2 and left Table 1 as-is.

Signed-off-by: Thomas Fossati <[email protected]>
See also ({{Section 2 of -rats-endorsements}}).

Appraisal Claims Set (ACS):
: A structure that holds ECTs that have been appraised.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: A structure that holds ECTs that have been appraised.
: A structure that holds ECTs ( for ECTs see below) that have been appraised.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look through the entries, this is not the only one.
There are constant references between the glossary entries, even 1:n.

Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!, just one minor point!

@yogeshbdeshpande
Copy link
Collaborator

And thanks for tidying this up!

@yogeshbdeshpande
Copy link
Collaborator

do we have reference to this glossary from first acronym use in the document??

@thomas-fossati
Copy link
Collaborator Author

do we have reference to this glossary from first acronym use in the document??

good catch! I have expanded ECT in all the entries (except ECT :-)).

Copy link
Collaborator

@nedmsmith nedmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see multiple comments

The ACS contains Attester state that has been authorized by Verifier processing and Appraisal Policy.

Appraisal Policy:
: A description of the conditions that, if met, allow acceptance of Claims.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: A description of the conditions that, if met, allow acceptance of Claims.
: A description of the conditions that, if met, allow appraisal of Claims.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptance is defined by the appraisal processing as defined in this spec. It isn't to be modified by profiles or policies. The wording could be misinterpreted to mean this, but could also be interpreted to mean the verifier selects which inputs are allowed based on policy.

@@ -190,20 +226,25 @@ The term "Target Environment" refers to the group of system security metrics tha
The term "Attesting Environment" refers to the entity that collects and cryptographically signs such security metrics.
See also {{Section 3.1 of -rats-arch}}.

Environment-Claim Tuple (ECT):
: A structure containing a set of values that describe a Target Environment plus a set of Measurement / Claim values that describe properties of the Target Environment.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
: A structure containing a set of values that describe a Target Environment plus a set of Measurement / Claim values that describe properties of the Target Environment.
: A structure containing a set of values that typically describe a Target Environment plus a set of Measurement / Claim values that describe properties of the Target Environment.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ECTs can contain claims about keys which might not be terminology that is intuitive when keys are described. Target Object is more intuitive. Note that Environment-map includes object identifiers, UUID, UEID, ect. that typically identify objects. There isn't perfect naming for this so I think its OK as is, but adding "typically" helps avoid nuanced discussions.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree: When Attest Key Triple introduces keys, ECT may also contain set of keys.

thomas-fossati and others added 2 commits February 20, 2025 22:07
Co-authored-by: Ned Smith <[email protected]>
Co-authored-by: Ned Smith <[email protected]>
Copy link
Collaborator

@nedmsmith nedmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yogeshbdeshpande
Copy link
Collaborator

@deeglaze & @andrew-draper : Please review it on Monday,(24th Feb), we plan to submit it today!

reference state:
: Claims that describe various alternative states of a Target Environment.
Reference Values Claims typically describe various possible states due to versioning, manufactruing practices, or supplier configuration options.
See also {{Section 2 of -rats-endorsements}}.

Reference Values:
: A set of values that represent the desired or undesired state of an Attester.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per #394 (comment):

Suggested change
: A set of values that represent the desired or undesired state of an Attester.
: A set of values that represent possible states of an Attester.

: An identifier of an Environment that is unique to that Environment instance, such as the serial number of a hardware module.
See also {{Section 4.2.1 of -eat}}.
reference state:
: Claims that describe various alternative states of a Target Environment.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition of reference state seems confusing to me! Is it alternative state or rather the most correct state or golden state of a target environment?

See also {{Section 4.2.1 of -eat}}.
reference state:
: Claims that describe various alternative states of a Target Environment.
Reference Values Claims typically describe various possible states due to versioning, manufacturing practices, or supplier configuration options.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Reference Values Claims typically describe various possible states due to versioning, manufacturing practices, or supplier configuration options.
Reference Values Claims typically describe various reference states from a target environment such as versioning, manufacturing practices, or supplier configuration options.

Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see few comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harmonise glossaries
3 participants