Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add registries for all map extension sockets #391

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

deeglaze
Copy link
Collaborator

The distinction of types for entity map sockets are suspect. Please discuss.

Closes Issue #223.

The distinction of types for entity map sockets are suspect. Please
discuss.

Closes Issue ietf-rats-wg#223.
Copy link
Collaborator

@nedmsmith nedmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@yogeshbdeshpande yogeshbdeshpande left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We'll be likely asked to add some instructions for the designated experts, but for now LGTM (modulo a couple of typos -- see inline)

@yogeshbdeshpande yogeshbdeshpande merged commit 72c7086 into ietf-rats-wg:main Feb 24, 2025
1 check passed
@yogeshbdeshpande
Copy link
Collaborator

Thank you @deeglaze for a great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants