Add EAT measured component to measurement-values-map
#395
Conversation
Fix #381 Signed-off-by: Thomas Fossati <[email protected]>
thomas-fossati
requested review from
henkbirkholz,
yogeshbdeshpande and
nedmsmith
as code owners
cddl/measurement-values-map.cddl
Outdated
| @@ -15,5 +15,6 @@ measurement-values-map = non-empty<{ | |||
| ? &(name: 11) => text | |||
| ? &(cryptokeys: 13) => [ + $crypto-key-type-choice ] | |||
| ? &(integrity-registers: 14) => integrity-registers | |||
| ? &(measured-component: 15) => measured-component | |||
There was a problem hiding this comment.
15 conflicts with the linear privlevel measurement PR.
There was a problem hiding this comment.
Oops, apologies. Will fix.
Signed-off-by: Thomas Fossati <[email protected]>
|
I find the compositional aspects of "measured components" confusing. Given the mkey is already a compositional element with is sub-component of an environment, what does it mean to have a sub-sub-element called a "component"? It seems the basic idea of using triples to enumerate various components or sub-components is being side-stepped toward composition expressed in terms of nesting. Most of the values in a measured component already exist in the measurement-values-map like digest, version, flags / raw-value. Mkey can support text identifiers which seems to map to It seems like a straight forward mapping without defining another layer of composition inside of measurement-values-map. |
Fix #381