Make cddl form for oemid consistent #473
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All claims have a separate rule for the type of value of the claim except oemid. This separate rule allows CDDL external to EAT to re use the type of a claim. The TEEP document would like to re use oemid this way, but can't because oemid is missing this separate rule.
This change adds the separate rule for the OEMID type so the TEEP can re use the type and so all claims consistently have this separate rule.
This doesn't change the EAT protocol in any way.
This was brought to us at the last minute by people working on TEEP and RATS.