Remove some default values/make some elements mandatory #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robUx4
added
clarifications
spec_main
mbunkus
approved these changes
May 30, 2021
retokromer
approved these changes
May 30, 2021
|
@robUx4 Branch has conflicts. Can you please rebase & then just merge? Thanks. |
This is likely unused and the fact it's a reversed number of lace is counter intuitive.
it's a tricky feature to use when it's not 0 so it's better to let people away from it
It's monoscopic video unless specified otherwise. There should not be an undefined.
The default value is not even the behavior video players do.
There should not be an undefined value and by default the DisplayWidth/Height are in pixels
Not being present is different as being present. When not present the CuePoint is still valid but we don't know which Block is the one we're looking for. Since we need to differentiate both, it cannot be mandatory and therefore the default value is useless.
robUx4
force-pushed
the
mandatory-defaults
branch
from
fe42cec to
9262b7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a default value when an element is not mandatory is confusing. We don't want to allow 0-length elements (#453).
Following the analysis in #310 here are some easy fixes.
Each commit explains one of the changes.