Re-use results of key inflection calls #103
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm chasing down some performance issues I'm seeing for some of our very large manifests. I noticed that it seems we pay the full price for each repeated
key.camelizecall. It might make sense to compute those once and re-use the saved value.Using the fixture data in our Purl app for https://purl.stanford.edu/bc854fy5899 to get to the point where we can return the result of
to_ordered_hashthe thememory_profilergem reports the following for this change:"allocated memory by gem" for activesupport-8.0.2 drops from 120401765 to 44878373
"allocated objects by gem" for activesupport-8.0.2 drops from 1600601 to 606617