Request cancel #340
Draft
Request cancel #340
+773
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make volumina request tiles more lazy by first submitting to a queue * tasks are submitted up to a limit to the lazyflow request pool * mechanism for cancelling/removing unsubmitted requests from the queue * As compared to before, ilastik will use way less memory (maybe half) This enables way better interactive usage of ilastik as number of requests that are submitted stays limited. Changing conditions (scrolling, dirtyness) trigger cancellation of queued requests that are not relevant anymore. Fixes ilastik#135 Fixes ilastik/ilastik#1735 Fixes ilastik/ilastik#1376, at least to a degree
time.time() is not guaranteed to be unique.
…azyflow, patch rendererpool, probably sequence of test now different so it used to work coincidentally
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
==========================================
+ Coverage 36.33% 36.92% +0.59%
==========================================
Files 108 109 +1
Lines 11439 11577 +138
==========================================
+ Hits 4156 4275 +119
- Misses 7283 7302 +19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
k-dominik
force-pushed
the
request-cancel
branch
from
adf6553 to
e88c248
Compare
k-dominik
commented
Oct 11, 2025
| from volumina.tiling.tileprovider import renderer_pool | ||
|
|
||
| renderer_pool.clear() | ||
| QApplication.processEvents() |
There was a problem hiding this comment.
kind of hard to get consistent full viewport updates, but processEvents() seems to do the trick
almost everything (except submit) was already operating under a lock, so the locking overhead of PriorityQueue can be omitted. Co-Authored-By: Emil Melnikov <[email protected]>
…azyflow, patch rendererpool, probably sequence of test now different so it used to work coincidentally
k-dominik
force-pushed
the
request-cancel
branch
from
e88c248 to
3bd1668
Compare
k-dominik
commented
Oct 15, 2025
| def clearPendingRequestQueueAndReferesh(self): | ||
| from volumina.tiling.tileprovider import renderer_pool | ||
|
|
||
| renderer_pool.clear() |
There was a problem hiding this comment.
refactor renderer_pool classes with common abc, as per @btbest's comment:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose RequestPool cancellation to ilastik - that way one can e.g. cancel live update.\
builds on top of #339
sister PR in ilastik: ilastik/ilastik#3082