Skip to content

Conversation

@majosm
Copy link
Collaborator

@majosm majosm commented Dec 15, 2021

Simplifies componentwise norm handling and implementation of filter_modally. No longer need special handling for single-species case.

⚠️ Depends on inducer/arraycontext#128, inducer/arraycontext#129, and inducer/grudge#199. ⚠️

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@majosm majosm force-pushed the simplify-component-norms branch from a17c555 to 49c3e73 Compare December 15, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant