Conversation
62e2940 to
acb5e11
Compare
Contributor
|
I'm trying to use this branch to compile an app I have, but I'm still getting an error: In lib/jennifer/src/jennifer/query_builder/nested_relation_tree.cr:31:29
31 | models = bucket.map(&.[1].model_class)
^
Error: type must be NoReturn, not PromptChain.classI get this exact error every time I try to define a I'm on MacOS 17.7.2 on Crystal 1.15.0 |
Contributor
|
Ok so, I can't reproduce this to another project yet. Apparently I just did something wild and it's breaking Jennifer some-how some-where 🤷♂️ |
Owner
Author
|
@crimson-knight could you pleases share with us how do you define those relations? Also does it mean when you comment them out everything is ok? |
Contributor
|
I was able to do some additional testing and it appears the crystal upgrade is unrelated. Commenting out the relationship macros does allow everything to compile. I'll have to do some additional testing to reproduce how I broke these macros 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support of crystal 1.15
Release notes
Please fill the corresponding section regarding this pull request notes below instead of modifying
CHANGELOG.mdfile. Please remove all redundant sections before posting request.General
Model
converterclass in column mapping is resolved globallyView
converterclass in column mapping is resolved globally